Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override

[Gleb Natapov <gleb@redhat.com>]

On Wed, May 06, 2009 at 06:35:20PM -0400, Beth Kon wrote:
> Sebastian Herbszt wrote:
>> Beth Kon wrote:
>>> @@ -477,6 +480,7 @@ void wrmsr_smp(uint32_t index, uint64_t val)
>>> #define QEMU_CFG_SIGNATURE  0x00
>>> #define QEMU_CFG_ID         0x01
>>> #define QEMU_CFG_UUID       0x02
>>> +#define QEMU_CFG_IRQ0_OVERRIDE 0x0e
>>
>> Small thing to consider before you resubmit:
>> In his patch "read-additional-acpi-tables-from-a-vm.patch" Gleb  
>> introduced:
>>
>> #define QEMU_CFG_ARCH_LOCAL     0x8000
>> #define QEMU_CFG_ACPI_TABLES  (QEMU_CFG_ARCH_LOCAL + 0)
>>
>> I think the idea behind this was to seperate the generic part from  
>> arch specific.
>> The IRQ0 override seems to be arch specific (x86 only?) just like the  
>> ACPI tables, right?
> I'm not sure what the intent is. It looks like it would be just for  
> additional tables (as opposed to "local")? Gleb? I don't believe irq0  
> override would fall into that category. But in any case since this is  
> not in any code base, I don't think there's anything to be done yet.
Local is for arch specific things like Sebastian said.

--
			Gleb.