Re: [PATCH] virtio_blk: don't blindly derefence req->rq_disk

Rusty Russell
2009-05-12T13:44:33Z

On Mon, 11 May 2009 06:05:19 pm Christoph Hellwig wrote:
> request->rq_disk is only set for FS requests or BLOCK_PC requests
> originating from the generic block layer scsi ioctls. It's not set
> for requests origination from other soures or internal cache flush
> commands implemented by the patch I'll send after this.
>
> So instead of using it to get at the private data in do_virtblk_request
> setup queue->queuedata and use it.

OK, shows how little I know about the block layer, seems fine.

Applied thanks,
Rusty.
(For those paying attention: we still need disk->private_data for get_geo).