From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH 2/2] Intel-IOMMU, intr-remap: source-id checking
Date: Mon, 11 May 2009 15:20:27 +0200
Message-ID: <20090511132027.GC32693@elte.hu>
References: <1241676996-27406-1-git-send-email-weidong.han@intel.com> <1241676996-27406-2-git-send-email-weidong.han@intel.com> <1241720381.27006.8582.camel@localhost.localdomain> <715D42877B251141A38726ABF5CABF2C01A6DD4900@pdsmsx503.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
To: "Han, Weidong" <weidong.han@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx3.mail.elte.hu ([157.181.1.138]:33858 "EHLO mx3.mail.elte.hu"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751318AbZEKNUl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 11 May 2009 09:20:41 -0400
Content-Disposition: inline
In-Reply-To: <715D42877B251141A38726ABF5CABF2C01A6DD4900@pdsmsx503.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


* Han, Weidong <weidong.han@intel.com> wrote:

> Siddha, Suresh B wrote:
> > On Wed, 2009-05-06 at 23:16 -0700, Han, Weidong wrote:
> >> @@ -634,6 +694,44 @@ static int ir_parse_ioapic_scope(struct
> >>  			       acpi_dmar_header *header, " 0x%Lx\n",
> >>  			       scope->enumeration_id, drhd->address);
> >> 
> >> +			bus = pci_find_bus(drhd->segment, scope->bus);
> >> +			path = (struct acpi_dmar_pci_path *)(scope + 1); +			count =
> >> (scope->length - +				 sizeof(struct acpi_dmar_device_scope))
> >> +				/ sizeof(struct acpi_dmar_pci_path);
> >> +
> >> +			while (count) {
> >> +				if (pdev)
> >> +					pci_dev_put(pdev);
> >> +
> >> +				if (!bus)
> >> +					break;
> >> +
> >> +				pdev = pci_get_slot(bus,
> >> +					PCI_DEVFN(path->dev, path->fn));
> >> +				if (!pdev)
> >> +					break;
> > 
> > ir_parse_ioapic_scope() happens very early in the boot. So, I 
> > don't think we can do the pci related discovery here.
> > 
> 
> Thanks for your pointing it out. It should enable the source-id 
> checking for io-apic's after the pci subsystem is up. I will 
> change it.

Note, there's ways to do early PCI quirks too, check 
arch/x86/kernel/early-quirks.c. It's done by reading the PCI 
configuration space directly via a careful early-capable subset of 
the PCI config space APIs.

But it's a method of last resort.

	Ingo