From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Habkost Subject: Re: [PATCH][KVM-AUTOTEST] Add custom install option for kvm_install Date: Mon, 11 May 2009 15:34:50 -0300 Message-ID: <20090511183450.GJ4871@blackpad> References: <443364434.369371242063386949.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> <4A0865D3.7020500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Michael Goldish , kvm@vger.kernel.org, Uri Lublin To: Mike Burns Return-path: Received: from mx2.redhat.com ([66.187.237.31]:42293 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755777AbZEKSex (ORCPT ); Mon, 11 May 2009 14:34:53 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4BIYtfn027911 for ; Mon, 11 May 2009 14:34:55 -0400 Content-Disposition: inline In-Reply-To: <4A0865D3.7020500@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 11, 2009 at 01:52:19PM -0400, Mike Burns wrote: > Michael Goldish wrote: >> 2. Why not just pass the parameters via the command line, e.g. >> install_command = my_script.sh param1 param2 >> > That would work as well. It could be done either way, but if someone > wanted to use something other than bash, then this way might be easier. What is bash-specific about environment variables or command-line args? Also, exporting the config dictionary as environment variables doesn't exclude the possibility of simply passing command-line arguments on install_command, if the user wants to do so. Both methods would work. -- Eduardo