From: Christoph Hellwig <hch@lst.de>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Christoph Hellwig <hch@lst.de>,
Rusty Russell <rusty@rustcorp.com.au>,
kvm@vger.kernel.org
Subject: Re: [PATCH, RFC] virtio_blk: add cache flush command
Date: Tue, 12 May 2009 09:26:27 +0200 [thread overview]
Message-ID: <20090512072627.GC5627@lst.de> (raw)
In-Reply-To: <4A085471.40809@codemonkey.ws>
On Mon, May 11, 2009 at 11:38:09AM -0500, Anthony Liguori wrote:
> >Right now it doesn't, but it probably should.
> >
>
> So then with cache=writeback, fsync behaves itself but O_DIRECT writes
> do not.
Right now O_DIRECT does not do an explicit cache flush, but due to the
way barriers are implemented in Linux we do get the cache flush as part
of the metadata updates after I/O completion.
> fsync is pretty crappy on ext3 default configs. I'm concerned that this
> could be considered a DoS by a malicious guest. If it sat in a T_FLUSH
> loop, it would potentially bring your system to a crawl, no?
It's exactly the same effect as a regular user doing fsync in a loop,
whatever that causes on ext3.
next prev parent reply other threads:[~2009-05-12 7:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 8:39 [PATCH, RFC] virtio_blk: add cache flush command Christoph Hellwig
2009-05-11 14:51 ` Anthony Liguori
2009-05-11 15:40 ` Christoph Hellwig
2009-05-11 15:45 ` Avi Kivity
2009-05-11 16:28 ` Christoph Hellwig
2009-05-11 16:49 ` Avi Kivity
2009-05-11 17:47 ` Anthony Liguori
2009-05-11 18:00 ` Avi Kivity
2009-05-11 18:29 ` Anthony Liguori
2009-05-11 18:40 ` Avi Kivity
2009-05-18 12:03 ` Christoph Hellwig
2009-05-12 7:23 ` Christoph Hellwig
2009-05-12 7:19 ` Christoph Hellwig
2009-05-12 8:35 ` Avi Kivity
2009-05-18 12:06 ` Christoph Hellwig
2009-05-11 16:38 ` Anthony Liguori
2009-05-12 7:26 ` Christoph Hellwig [this message]
2009-05-12 13:54 ` Rusty Russell
2009-05-12 14:18 ` Christian Borntraeger
2009-05-13 1:52 ` Rusty Russell
2009-05-18 12:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090512072627.GC5627@lst.de \
--to=hch@lst.de \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox