From: Rusty Russell <rusty@rustcorp.com.au>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] virtio_blk: don't blindly derefence req->rq_disk
Date: Tue, 12 May 2009 23:14:21 +0930 [thread overview]
Message-ID: <200905122314.22354.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090511083519.GA20082@lst.de>
On Mon, 11 May 2009 06:05:19 pm Christoph Hellwig wrote:
> request->rq_disk is only set for FS requests or BLOCK_PC requests
> originating from the generic block layer scsi ioctls. It's not set
> for requests origination from other soures or internal cache flush
> commands implemented by the patch I'll send after this.
>
> So instead of using it to get at the private data in do_virtblk_request
> setup queue->queuedata and use it.
OK, shows how little I know about the block layer, seems fine.
Applied thanks,
Rusty.
(For those paying attention: we still need disk->private_data for get_geo).
prev parent reply other threads:[~2009-05-12 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 8:35 [PATCH] virtio_blk: don't blindly derefence req->rq_disk Christoph Hellwig
2009-05-12 13:44 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905122314.22354.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=hch@lst.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox