From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] virtio_blk: don't blindly derefence req->rq_disk
Date: Tue, 12 May 2009 23:14:21 +0930
Message-ID: <200905122314.22354.rusty@rustcorp.com.au>
References: <20090511083519.GA20082@lst.de>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:55778 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752311AbZELNod (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 12 May 2009 09:44:33 -0400
In-Reply-To: <20090511083519.GA20082@lst.de>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 11 May 2009 06:05:19 pm Christoph Hellwig wrote:
> request->rq_disk is only set for FS requests or BLOCK_PC requests
> originating from the generic block layer scsi ioctls.  It's not set
> for requests origination from other soures or internal cache flush
> commands implemented by the patch I'll send after this.
>
> So instead of using it to get at the private data in do_virtblk_request
> setup queue->queuedata and use it.

OK, shows how little I know about the block layer, seems fine.

Applied thanks,
Rusty.
(For those paying attention: we still need disk->private_data for get_geo).