From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: Enable IRQ windows after exception injection if there are pending virq Date: Wed, 13 May 2009 13:29:04 +0300 Message-ID: <20090513102904.GU18554@redhat.com> References: <20090508122358.GF25357@redhat.com> <9832F13BD22FB94A829F798DA4A8280501A81A8F2B@pdsmsx503.ccr.corp.intel.com> <20090508184417.GA27255@redhat.com> <9832F13BD22FB94A829F798DA4A8280501A81A9078@pdsmsx503.ccr.corp.intel.com> <20090511060224.GH18554@redhat.com> <9832F13BD22FB94A829F798DA4A8280501B24E53E6@pdsmsx503.ccr.corp.intel.com> <20090512070113.GB1013@redhat.com> <9832F13BD22FB94A829F798DA4A8280501B24E5674@pdsmsx503.ccr.corp.intel.com> <20090512152714.GN19446@redhat.com> <9832F13BD22FB94A829F798DA4A8280501B24E5AEF@pdsmsx503.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , "kvm@vger.kernel.org" To: "Dong, Eddie" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:59684 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758622AbZEMK3G (ORCPT ); Wed, 13 May 2009 06:29:06 -0400 Content-Disposition: inline In-Reply-To: <9832F13BD22FB94A829F798DA4A8280501B24E5AEF@pdsmsx503.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, May 13, 2009 at 03:45:37PM +0800, Dong, Eddie wrote: > Gleb Natapov wrote: > > On Tue, May 12, 2009 at 11:06:39PM +0800, Dong, Eddie wrote: > >> > >> I didn't take many test since our PTS system stop working now due to > >> KVM userspace > >> build changes. But since the logic is pretty simple, so I want to > >> post here to see comments. Thx, eddie > >> > >> > >> > >> > >> If there is pending irq after an virtual exception is injected, > >> KVM needs to enable IRQ window to trap back earlier once > >> the exception is handled. > >> > > I already posted patch to do that > > http://patchwork.kernel.org/patch/21830/ Is you patch different? > > > Is it base on the idea I mentioned to you in private mail (April 27), or a novel one? > Yes. It fixes the bug you pointed out. -- Gleb.