Re: [PATCH 1/3] virtio: find_vqs/del_vqs virtio operations

Rusty Russell
2009-05-12T13:03:28Z

On Sun, 10 May 2009 04:55:38 pm Michael S. Tsirkin wrote:
> On Sun, May 10, 2009 at 01:37:06PM +0930, Rusty Russell wrote:
> > Yes, and in fact a rough look at your patch reveals that we don't
> > actually need del_vq: now we track them, we can just do that as part of
> > vdev destruction, right?
>
> Let's assume that a driver encounters an error in probe
> after it calls find_vq. It would need a way to revert
> find_vq, won't it?
>
> It seems to me that bus->remove does not get called
> on probe failure. Isn't that right?

Yep, I looked too fast.

Thanks,
Rusty.