From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v3] kvm: Use a bitmap for tracking used GSIs Date: Wed, 13 May 2009 17:25:06 +0300 Message-ID: <20090513142506.GF31593@redhat.com> References: <20090508222925.5119.94814.stgit@dl380g6-3.ned.telco.ned.telco> <20090512220142.5663.72948.stgit@dl380g6-3.ned.telco.ned.telco> <20090513070451.GB31139@redhat.com> <1242217175.4786.50.camel@2710p.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, sheng.yang@intel.com To: Alex Williamson Return-path: Received: from mx2.redhat.com ([66.187.237.31]:52000 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756865AbZEMO0G (ORCPT ); Wed, 13 May 2009 10:26:06 -0400 Content-Disposition: inline In-Reply-To: <1242217175.4786.50.camel@2710p.home> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, May 13, 2009 at 06:19:35AM -0600, Alex Williamson wrote: > On Wed, 2009-05-13 at 10:04 +0300, Michael S. Tsirkin wrote: > > On Tue, May 12, 2009 at 04:07:15PM -0600, Alex Williamson wrote: > > > @@ -286,6 +289,9 @@ kvm_context_t kvm_init(struct kvm_callbacks *callbacks, > > > int fd; > > > kvm_context_t kvm; > > > int r; > > > +#ifdef KVM_CAP_IRQ_ROUTING > > > > Let's kill all these ifdefs. Or at least, let's not add them. > > AFAICT, they're still used both for builds against older kernels and > architectures that don't support it. architectures only, I think. you don't know what kernel you will run on, at build time. > Hollis just added the one around > kvm_get_irq_route_gsi() 10 days ago to fix ppc build. Has it since been > deprecated? Thanks, > > Alex > These should be local to libkvm I think. I think kvm_get_gsi_count already returns an error on ppc, so things should work without ifdefs. -- MST