From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ryan Harper Subject: Re: [PATCH] don't use a 32-bit bit type as offset argument. Date: Wed, 13 May 2009 15:23:57 -0500 Message-ID: <20090513202357.GZ3233@us.ibm.com> References: <1242242474-7599-1-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from e6.ny.us.ibm.com ([32.97.182.146]:33982 "EHLO e6.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755626AbZEMUX5 (ORCPT ); Wed, 13 May 2009 16:23:57 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n4DKQEYm027567 for ; Wed, 13 May 2009 16:26:14 -0400 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.2) with ESMTP id n4DKNwXU202040 for ; Wed, 13 May 2009 16:23:58 -0400 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n4DKNwML004389 for ; Wed, 13 May 2009 16:23:58 -0400 Content-Disposition: inline In-Reply-To: <1242242474-7599-1-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: * Glauber Costa [2009-05-13 14:22]: > In the call path of kvm_get_dirty_pages_log_range(), > its caller kvm_get_dirty_bitmap_cb() passes the > target_phys_addr_t both as start_addr and the offset. > So, using int will make dirty tracking over 4G fail > completely. Does this patch fix someting like 32-bit migration with >4G ? Seems like it might. > > Of course we should be using qemu types in > here, so please don't get me started on this. The whole > file is wrong already ;) > > Signed-off-by: Glauber Costa > --- > qemu-kvm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/qemu-kvm.c b/qemu-kvm.c > index f55cee8..27c37b5 100644 > --- a/qemu-kvm.c > +++ b/qemu-kvm.c > @@ -1201,7 +1201,7 @@ int kvm_physical_memory_set_dirty_tracking(int enable) > /* get kvm's dirty pages bitmap and update qemu's */ > static int kvm_get_dirty_pages_log_range(unsigned long start_addr, > unsigned char *bitmap, > - unsigned int offset, > + unsigned long offset, > unsigned long mem_size) > { > unsigned int i, j, n=0; > -- > 1.5.6.6 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh@us.ibm.com