From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR) Date: Wed, 13 May 2009 21:57:02 +0000 Message-ID: <200905132157.02633.arnd@arndb.de> References: <1242203541-12959-1-git-send-email-markmc@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from moutng.kundenserver.de ([212.227.126.188]:63850 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752811AbZEMV5G (ORCPT ); Wed, 13 May 2009 17:57:06 -0400 In-Reply-To: <1242203541-12959-1-git-send-email-markmc@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 13 May 2009 08:32:21 Mark McLoughlin wrote: > Currently we only include $(KERNELDIR)/include in CFLAGS, > but we also have $(KERNELDIR)/arch/$(arch)/include or else > we'll get mis-matched headers. > I think this is fundamentally wrong. User files should never directly access kernel headers, because they are postprocessed in various ways in order to get files that are valid in user space, e.g. __user annotations are removed. The three possible sources for kernel headers are: /usr/include - system provided headers, may be older than the running kernel /lib/modules/$(uname -r)/build/usr/include - user space headers for the currently running kernel $(KERNELDIR)/usr/include - user space headers from a configured kernel tree after 'make headers_install' Arnd <><