From: Arnd Bergmann <arnd@arndb.de>
To: Avi Kivity <avi@redhat.com>
Cc: Mark McLoughlin <markmc@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR)
Date: Thu, 14 May 2009 17:49:53 +0200 [thread overview]
Message-ID: <200905141749.54453.arnd@arndb.de> (raw)
In-Reply-To: <4A0BD02B.1020009@redhat.com>
On Thursday 14 May 2009, Avi Kivity wrote:
>
> There aren't the real kernel headers, just cheap copies carried in
> qemu-kvm.git which have been appropriately postprocessed. We do this
> since the kvm external module can run on a much older kernel, so there
> is no natural place to find it headers.
>
Sorry for the confusion on my part. I was aware of the sanitized
kernel headers, but was mislead by the line
kerneldir=/lib/modules/$(uname -r)/build
in kvm/user/configure. What I didn't realize is that this
always gets overridden by kvm/configure.
Maybe we can change the default in kvm/user/configure to
something more sensible:
---
[PATCH] kvm: user: fix default kerneldir
calling ./configure in kvm/user sets the kerneldir to the
currently running kernel, which is incorrect for user code.
This changes the default to the sanitized header files from
the kvm/kernel directory.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/kvm/user/configure b/kvm/user/configure
index efb8705..858a519 100755
--- a/kvm/user/configure
+++ b/kvm/user/configure
@@ -1,7 +1,7 @@
#!/bin/bash
prefix=/usr/local
-kerneldir=/lib/modules/$(uname -r)/build
+kerneldir="$(dirname $0)/../kernel"
cc=gcc
ld=ld
objcopy=objcopy
next prev parent reply other threads:[~2009-05-14 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 8:32 [PATCH] kvm: user: include arch specific headers from $(KERNELDIR) Mark McLoughlin
2009-05-13 21:57 ` Arnd Bergmann
2009-05-14 7:52 ` Mark McLoughlin
2009-05-14 8:02 ` Avi Kivity
2009-05-14 15:49 ` Arnd Bergmann [this message]
2009-05-14 15:55 ` Avi Kivity
2009-05-14 16:07 ` Arnd Bergmann
2009-05-17 22:18 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905141749.54453.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox