From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] kvm: user: include arch specific headers from $(KERNELDIR) Date: Thu, 14 May 2009 17:49:53 +0200 Message-ID: <200905141749.54453.arnd@arndb.de> References: <1242203541-12959-1-git-send-email-markmc@redhat.com> <200905132157.02633.arnd@arndb.de> <4A0BD02B.1020009@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Mark McLoughlin , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from moutng.kundenserver.de ([212.227.126.186]:57180 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753348AbZENPuN convert rfc822-to-8bit (ORCPT ); Thu, 14 May 2009 11:50:13 -0400 In-Reply-To: <4A0BD02B.1020009@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Thursday 14 May 2009, Avi Kivity wrote: >=20 > There aren't the real kernel headers, just cheap copies carried in=20 > qemu-kvm.git which have been appropriately postprocessed. =A0We do th= is=20 > since the kvm external module can run on a much older kernel, so ther= e=20 > is no natural place to find it headers. >=20 Sorry for the confusion on my part. I was aware of the sanitized kernel headers, but was mislead by the line kerneldir=3D/lib/modules/$(uname -r)/build in kvm/user/configure. What I didn't realize is that this always gets overridden by kvm/configure. Maybe we can change the default in kvm/user/configure to something more sensible: --- [PATCH]=A0kvm: user: fix default kerneldir calling ./configure in kvm/user sets the kerneldir to the currently running kernel, which is incorrect for user code. This changes the default to the sanitized header files from the kvm/kernel directory. Signed-off-by: Arnd Bergmann diff --git a/kvm/user/configure b/kvm/user/configure index efb8705..858a519 100755 --- a/kvm/user/configure +++ b/kvm/user/configure @@ -1,7 +1,7 @@ #!/bin/bash =20 prefix=3D/usr/local -kerneldir=3D/lib/modules/$(uname -r)/build +kerneldir=3D"$(dirname $0)/../kernel" cc=3Dgcc ld=3Dld objcopy=3Dobjcopy