From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 6/6] Nested SVM: Improve interrupt injection
Date: Sun, 17 May 2009 09:48:57 +0300
Message-ID: <20090517064857.GF3909@redhat.com>
References: <1242375740-31222-1-git-send-email-agraf@suse.de> <1242375740-31222-2-git-send-email-agraf@suse.de> <1242375740-31222-3-git-send-email-agraf@suse.de> <1242375740-31222-4-git-send-email-agraf@suse.de> <1242375740-31222-5-git-send-email-agraf@suse.de> <1242375740-31222-6-git-send-email-agraf@suse.de> <1242375740-31222-7-git-send-email-agraf@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, joerg.roedel@amd.com
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:55573 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751403AbZEQGtC (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 17 May 2009 02:49:02 -0400
Content-Disposition: inline
In-Reply-To: <1242375740-31222-7-git-send-email-agraf@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, May 15, 2009 at 10:22:20AM +0200, Alexander Graf wrote:
>  static void svm_set_irq(struct kvm_vcpu *vcpu, int irq)
>  {
>  	struct vcpu_svm *svm = to_svm(vcpu);
>  
> -	nested_svm_intr(svm);
> +	if(!(svm->vcpu.arch.hflags & HF_GIF_MASK))
> +		return;
>  
Why would this function be called if HF_GIF_MASK is not set? This
check is done in svm_interrupt_allowed().

> -	svm_queue_irq(vcpu, irq);
> +	svm->vmcb->control.event_inj = irq |
> +		SVM_EVTINJ_VALID | SVM_EVTINJ_TYPE_INTR;
>  }
>  

--
			Gleb.