From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] Set bit 1 in disabled processor's _STA
Date: Sun, 17 May 2009 11:23:47 +0300
Message-ID: <20090517082347.GG3909@redhat.com>
References: <1242389683-12967-1-git-send-email-glommer@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, avi@redhat.com
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:60833 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751704AbZEQIXt (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 17 May 2009 04:23:49 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4H8NoRR026729
	for <kvm@vger.kernel.org>; Sun, 17 May 2009 04:23:50 -0400
Content-Disposition: inline
In-Reply-To: <1242389683-12967-1-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote:
> This patch sets bits 1 in disabled processor's _STA.
> According to the ACPI spec, this bit means:
>  "Set if the device is enabled and decoding its resources."
> 
> Without it, Windows 2008 device manager shows the processors
> as malfunctioning hardware.
> 
If you uncheck "show hidden devices" option in View menu of the
device manager you should see only enabled CPUs (bit 2 of _STA).
This patch breaks resume from hibernate on windows 2008/vista.

> Signed-off-by: Glauber Costa <glommer@redhat.com>
> ---
>  kvm/bios/acpi-dsdt.dsl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kvm/bios/acpi-dsdt.dsl b/kvm/bios/acpi-dsdt.dsl
> index c756fed..c53816c 100755
> --- a/kvm/bios/acpi-dsdt.dsl
> +++ b/kvm/bios/acpi-dsdt.dsl
> @@ -56,7 +56,7 @@ DefinitionBlock (
>              }                                                               \
>              Method (_STA) {                                                 \
>                  If (CRST(nr)) { Return(0xF) }                               \
> -                Else { Return(0x9) }                                        \
> +                Else { Return(0xB) }                                        \
>              }                                                               \
>          }                                                                   \
>  
> -- 
> 1.5.6.6
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
			Gleb.