Re: [PATCH] Set bit 1 in disabled processor's _STA

Gleb Natapov
2009-05-17T14:30:07Z

On Sun, May 17, 2009 at 10:27:41AM -0300, Glauber Costa wrote:
> On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote:
> > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote:
> > > This patch sets bits 1 in disabled processor's _STA.
> > > According to the ACPI spec, this bit means:
> > > "Set if the device is enabled and decoding its resources."
> > >
> > > Without it, Windows 2008 device manager shows the processors
> > > as malfunctioning hardware.
> > >
> > If you uncheck "show hidden devices" option in View menu of the
> > device manager you should see only enabled CPUs (bit 2 of _STA).
> Yes, that is what happens. But then, by checking "show hidden devices",
> the disabled processor appears, but are listed as malfunctioning.
>
> Because of this, SVVP tests break without this patch.
>
What kind of error?

> > This patch breaks resume from hibernate on windows 2008/vista.
> Oh god... do you have any idea why?
>
> which bits should we set for everything to work?
Bit 1 should not be set :) What I think is happening windows finds more
CPUs on resume then it had before hibernate.

> It appears to me that having bit 2 cleared should do the right thing,
> but your test clearly indicate otherwise.

--
Gleb.