From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] Set bit 1 in disabled processor's _STA Date: Sun, 17 May 2009 17:30:06 +0300 Message-ID: <20090517143006.GJ3909@redhat.com> References: <1242389683-12967-1-git-send-email-glommer@redhat.com> <20090517082347.GG3909@redhat.com> <20090517132741.GL27295@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:58049 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750854AbZEQOaH (ORCPT ); Sun, 17 May 2009 10:30:07 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4HEU8Ax023091 for ; Sun, 17 May 2009 10:30:08 -0400 Content-Disposition: inline In-Reply-To: <20090517132741.GL27295@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, May 17, 2009 at 10:27:41AM -0300, Glauber Costa wrote: > On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > > This patch sets bits 1 in disabled processor's _STA. > > > According to the ACPI spec, this bit means: > > > "Set if the device is enabled and decoding its resources." > > > > > > Without it, Windows 2008 device manager shows the processors > > > as malfunctioning hardware. > > > > > If you uncheck "show hidden devices" option in View menu of the > > device manager you should see only enabled CPUs (bit 2 of _STA). > Yes, that is what happens. But then, by checking "show hidden devices", > the disabled processor appears, but are listed as malfunctioning. > > Because of this, SVVP tests break without this patch. > What kind of error? > > This patch breaks resume from hibernate on windows 2008/vista. > Oh god... do you have any idea why? > > which bits should we set for everything to work? Bit 1 should not be set :) What I think is happening windows finds more CPUs on resume then it had before hibernate. > It appears to me that having bit 2 cleared should do the right thing, > but your test clearly indicate otherwise. -- Gleb.