From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH] Set bit 1 in disabled processor's _STA Date: Sun, 17 May 2009 11:31:07 -0300 Message-ID: <20090517143107.GM27295@poweredge.glommer> References: <1242389683-12967-1-git-send-email-glommer@redhat.com> <20090517082347.GG3909@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Gleb Natapov Return-path: Received: from mx2.redhat.com ([66.187.237.31]:57702 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752682AbZEQO0E (ORCPT ); Sun, 17 May 2009 10:26:04 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4HEQ5vb022148 for ; Sun, 17 May 2009 10:26:05 -0400 Content-Disposition: inline In-Reply-To: <20090517082347.GG3909@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, May 17, 2009 at 11:23:47AM +0300, Gleb Natapov wrote: > On Fri, May 15, 2009 at 08:14:43AM -0400, Glauber Costa wrote: > > This patch sets bits 1 in disabled processor's _STA. > > According to the ACPI spec, this bit means: > > "Set if the device is enabled and decoding its resources." > > > > Without it, Windows 2008 device manager shows the processors > > as malfunctioning hardware. > > > If you uncheck "show hidden devices" option in View menu of the > device manager you should see only enabled CPUs (bit 2 of _STA). > This patch breaks resume from hibernate on windows 2008/vista. The last change on that piece of code was made by you under the comment: 1) Disabled processor's _STA method should return 0 (this fixes Vista's BSOD on resuming after hibernate problem) However, you did not changed it to 0, but to 9 instead. What did you meant? It appears that windows won't accept bit 0 without bit 1 being set. However, it works fine in my use case if _STA returns 0 or 8. The only real problem is, as I said, setting bit 0 but not bit 1. Does any among 0 or 8 works for your hibernate use case?