From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH 06/17] Use statfs to determine size of huge pages Date: Mon, 18 May 2009 11:02:30 +0200 Message-ID: <20090518090230.GZ9835@amd.com> References: <1242574999-20887-1-git-send-email-aliguori@us.ibm.com> <1242574999-20887-7-git-send-email-aliguori@us.ibm.com> <4A1042B8.2010407@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , kvm@vger.kernel.org, Glauber Costa To: Avi Kivity Return-path: Received: from sg2ehsobe003.messaging.microsoft.com ([207.46.51.77]:29086 "EHLO SG2EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752020AbZERJC5 convert rfc822-to-8bit (ORCPT ); Mon, 18 May 2009 05:02:57 -0400 Content-Disposition: inline In-Reply-To: <4A1042B8.2010407@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sun, May 17, 2009 at 08:00:40PM +0300, Avi Kivity wrote: > Anthony Liguori wrote: >> From: Joerg Roedel >> >> The current method of finding out the size of huge pages does not wo= rk >> reliably anymore. Current Linux supports more than one huge page siz= e >> but /proc/meminfo only show one of the supported sizes. >> To find out the real page size used can be found by calling statfs. = This >> patch changes qemu to use statfs instead of parsing /proc/meminfo. >> =20 > > Since we don't support 1GBpages in stable-0.10, this is unneeded. This patch is needed to run current KVM on a hugetlbfs backed with 1GB pages. Therefore I think this patch is needed. It is an improvement over the /proc/meminfo parsing anyway and is not strictly related to kvm kernel support for 1GB pages. Joerg --=20 | Advanced Micro Devices GmbH Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei M=FCnchen System |=20 Research | Gesch=E4ftsf=FChrer: Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen | Registergericht M=FCnchen, HRB Nr. 43632