From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] cleanup arch/x86/kvm/Makefile Date: Mon, 18 May 2009 10:07:56 -0400 Message-ID: <20090518140756.GA22138@infradead.org> References: <20090518121614.GA698@infradead.org> <4A116B46.3040303@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:57750 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbZEROHy (ORCPT ); Mon, 18 May 2009 10:07:54 -0400 Content-Disposition: inline In-Reply-To: <4A116B46.3040303@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, May 18, 2009 at 05:05:58PM +0300, Avi Kivity wrote: > Christoph Hellwig wrote: >> Use proper foo-y style list additions to cleanup all the conditionals, >> move module selection after compound object selection and remove the >> superflous comment. >> >> > > I think you're patching the wrong tree. > >> -kvm-objs := $(common-objs) x86.o mmu.o x86_emulate.o i8259.o irq.o lapic.o \ >> - i8254.o >> > > I have a timer.o here, for example. It's current mainline as of today.