From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 05/17] Stop/start cpus before/after devices
Date: Mon, 18 May 2009 11:47:29 -0300
Message-ID: <20090518144729.GD3168@amt.cnet>
References: <1242574999-20887-1-git-send-email-aliguori@us.ibm.com> <1242574999-20887-6-git-send-email-aliguori@us.ibm.com> <4A104287.6080000@redhat.com> <20090518135843.GB3168@amt.cnet> <4A117017.400@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org,
	Glauber Costa <glommer@gmail.com>,
	Yaniv Kamay <yaniv@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:52312 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751101AbZEROsV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 18 May 2009 10:48:21 -0400
Content-Disposition: inline
In-Reply-To: <4A117017.400@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, May 18, 2009 at 09:26:31AM -0500, Anthony Liguori wrote:
> Marcelo Tosatti wrote:
>> On Sun, May 17, 2009 at 07:59:51PM +0300, Avi Kivity wrote:
>>   
>>> Anthony Liguori wrote:
>>>     
>>>> From: Yaniv Kamay <yaniv@qumranet.com>
>>>>
>>>> Stop cpus before devices when stopping the VM, start cpus after devices
>>>> when starting VM.  Otherwise a vcpu could access a stopped device.
>>>>
>>>>         
>>> IIRC we decided this was unnecessary since everything is under   
>>> qemu_mutex.  However we might want to be on the safe side here and be 
>>>  similar to master.
>>>     
>>
>> Yes, it is not necessary. Since upstream is already on the safe side
>> (and the plan is to merge with it), IMO better leave this patch out.
>>   
>
> Maybe it ought to be reverted from master then?

Nope, its likelt to be useful in the future.