From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 5/6] Nested SVM: Implement INVLPGA
Date: Mon, 18 May 2009 15:46:20 -0300
Message-ID: <20090518184620.GA15749@amt.cnet>
References: <1242375740-31222-1-git-send-email-agraf@suse.de> <1242375740-31222-2-git-send-email-agraf@suse.de> <1242375740-31222-3-git-send-email-agraf@suse.de> <1242375740-31222-4-git-send-email-agraf@suse.de> <1242375740-31222-5-git-send-email-agraf@suse.de> <1242375740-31222-6-git-send-email-agraf@suse.de> <20090515134301.GX9835@amd.com> <4A106D49.7080600@redhat.com> <4A106DA8.6070200@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	Alexander Graf <agraf@suse.de>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:55524 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751398AbZERSre (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 18 May 2009 14:47:34 -0400
Content-Disposition: inline
In-Reply-To: <4A106DA8.6070200@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, May 17, 2009 at 11:03:52PM +0300, Avi Kivity wrote:
> Avi Kivity wrote:
>>>
>>> Hmm, since we flush the TLB on every nested-guest entry I think we can
>>> make this function a nop.
>>>   
>>
>> I think, unless it specified ASID 0?  In that case you need a local  
>> tlb flush.
>>
>> (the kvm_mmu_reset_context() and kvm_mmu_load() are total overkills in  
>> any case).
>>
>
> Oh, but we do need to resync OOS pages, here for ASID 0 and on guest  
> entry.  Marcelo?

Right, call kvm_mmu_invlpg() with the linear address passed to INVLPGA.