From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [patch 3/4] KVM: introduce irq_lock, use it protect ioapic
Date: Wed, 20 May 2009 11:11:34 -0300
Message-ID: <20090520141134.GB3370@amt.cnet>
References: <20090518165601.747763120@localhost.localdomain> <20090518170855.484310662@localhost.localdomain> <4A13F377.3030500@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:51099 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753897AbZETOTV (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 20 May 2009 10:19:21 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n4KEJMhN031197
	for <kvm@vger.kernel.org>; Wed, 20 May 2009 10:19:22 -0400
Content-Disposition: inline
In-Reply-To: <4A13F377.3030500@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, May 20, 2009 at 03:11:35PM +0300, Avi Kivity wrote:
> Marcelo Tosatti wrote:
>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>>
>> Index: kvm/include/linux/kvm_host.h
>> ===================================================================
>> --- kvm.orig/include/linux/kvm_host.h
>> +++ kvm/include/linux/kvm_host.h
>> @@ -123,7 +123,6 @@ struct kvm_kernel_irq_routing_entry {
>>  };
>>   struct kvm {
>> -	struct mutex lock; /* protects the vcpus array and APIC accesses */
>>   
>
> Why move?

To have it close to the data it protects, for readability. Need to
pahole and organize it at some point.