Re: [patch 3/4] KVM: introduce irq_lock, use it protect ioapic

Avi Kivity
2009-05-20T14:29:46Z

Marcelo Tosatti wrote:
> On Wed, May 20, 2009 at 03:11:35PM +0300, Avi Kivity wrote:
>
>> Marcelo Tosatti wrote:
>>
>>> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>>>
>>> Index: kvm/include/linux/kvm_host.h
>>> ===================================================================
>>> --- kvm.orig/include/linux/kvm_host.h
>>> +++ kvm/include/linux/kvm_host.h
>>> @@ -123,7 +123,6 @@ struct kvm_kernel_irq_routing_entry {
>>> };
>>> struct kvm {
>>> - struct mutex lock; /* protects the vcpus array and APIC accesses */
>>>
>>>
>> Why move?
>>
>
> To have it close to the data it protects, for readability. Need to
> pahole and organize it at some point.
>
>

Ok.

--
error compiling committee.c: too many arguments to function