From: Chris Wright <chrisw@sous-sol.org>
To: Avi Kivity <avi@redhat.com>
Cc: Chris Wright <chrisw@sous-sol.org>, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm-kmod: fix kvm_request_irq race
Date: Wed, 20 May 2009 23:38:16 -0700 [thread overview]
Message-ID: <20090521063816.GT20823@sequoia.sous-sol.org> (raw)
In-Reply-To: <4A14F4AD.9060408@redhat.com>
* Avi Kivity (avi@redhat.com) wrote:
> Since this mutex is in a header file, it can be instantiated multiple
> times. It will only serialize callers within a translation unit.
> Please define it in a C file.
>
> Would be best to move the the code as well.
Yeah it seems to get linked multiple times (when I tried that I found
duplicates). I'll look again.
thanks,
-chris
next prev parent reply other threads:[~2009-05-21 6:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-21 6:21 [PATCH] kvm-kmod: fix kvm_request_irq race Chris Wright
2009-05-21 6:29 ` Avi Kivity
2009-05-21 6:38 ` Chris Wright [this message]
2009-05-21 7:38 ` [PATCH kvm-kmod v2] " Chris Wright
2009-05-21 7:45 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090521063816.GT20823@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox