From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 1/2] Add serial number support for virtio_blk, V3
Date: Wed, 27 May 2009 09:51:33 +0200
Message-ID: <20090527075133.GA7795@lst.de>
References: <4A1C88CD.2090406@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: KVM list <kvm@vger.kernel.org>, qemu-devel@nongnu.org
To: john cooper <john.cooper@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.210]:55721 "EHLO verein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752274AbZE0Hvr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 27 May 2009 03:51:47 -0400
Content-Disposition: inline
In-Reply-To: <4A1C88CD.2090406@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Looks good to me.  In a couple of places you have spaces beforing
the opening brace as in:

+    memcpy(&blkcfg.serial, s->serial_str, sizeof (blkcfg.serial));

which is not the style used in the surrounding code, I'd suggest
removing them.