From mboxrd@z Thu Jan  1 00:00:00 1970
From: Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3
Date: Wed, 27 May 2009 22:23:26 +0930
Message-ID: <200905272223.27614.rusty@rustcorp.com.au>
References: <4A1C88DE.6050608@redhat.com> <20090527074919.GB7356@lst.de>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: john cooper <john.cooper@redhat.com>,
	KVM list <kvm@vger.kernel.org>, qemu-devel@nongnu.org
To: Christoph Hellwig <hch@lst.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from ozlabs.org ([203.10.76.45]:45561 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759165AbZE1DqF (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 27 May 2009 23:46:05 -0400
In-Reply-To: <20090527074919.GB7356@lst.de>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, 27 May 2009 05:19:19 pm Christoph Hellwig wrote:
> You should probably include rusty as he's collecting the patches
> for the virtio guest drivers.

Yes.  It *does* help to cc the maintainer if you want your patches applied :)

And I particularly love untested code like this!

> +	if (!(id = kzalloc(ATA_ID_WORDS, GFP_KERNEL)))
> +		rv = -ENOMEM;

Doesn't ATA_ID_WORDS seem like a strange name for a number of bytes?

What's this *for* BTW?
Rusty.