Re: [patch 2/4] KVM: move coalesced_mmio locking to its own device

Avi Kivity
2009-05-20T14:29:24Z

Marcelo Tosatti wrote:

>> So we have a function that takes a lock and conditionally releases it?
>>
>
> Yes, but it is correct: it will only return with the lock held in case
> it returns 1, in which case its guaranteed ->write will be called (which
> will unlock it).
>
> It should check the range first and/or use some smarter synchronization,
> but one thing at a time.
>

Yes it's correct but we'll get an endless stream of patches to 'fix' it
because it is so unorthodox.

--
error compiling committee.c: too many arguments to function