From: Chris Wright <chrisw@sous-sol.org>
To: Gregory Haskins <ghaskins@novell.com>
Cc: avi@redhat.com, chrisw@sous-sol.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [KVM PATCH v3 1/3] kvm: fix potential coalesced_mmio leak on shutdown
Date: Mon, 1 Jun 2009 10:06:13 -0700 [thread overview]
Message-ID: <20090601170613.GS20823@sequoia.sous-sol.org> (raw)
In-Reply-To: <20090601165445.18202.2291.stgit@dev.haskins.net>
* Gregory Haskins (ghaskins@novell.com) wrote:
> It would appear that we are invoking kfree() on the wrong pointer in the
> destructor for the coalesced_mmio device. This could result in a potential
> leak during shutdown. This works today because the kvm_io_device is
> the first element of the private structure, but this could change in
> the future, so lets clean this up.
>
> Signed-off-by: Gregory Haskins <ghaskins@novell.com>
Acked-by: Chris Wright <chrisw@sous-sol.org>
next prev parent reply other threads:[~2009-06-01 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 16:54 [KVM PATCH v3 0/3] mmio/pio cleanup Gregory Haskins
2009-06-01 16:54 ` [KVM PATCH v3 1/3] kvm: fix potential coalesced_mmio leak on shutdown Gregory Haskins
2009-06-01 17:06 ` Chris Wright [this message]
2009-06-01 16:54 ` [KVM PATCH v3 2/3] kvm: cleanup io_device code Gregory Haskins
2009-06-01 17:06 ` Chris Wright
2009-06-01 16:54 ` [KVM PATCH v3 3/3] kvm: do not register i8254 PIO regions until we are initialized Gregory Haskins
2009-06-01 17:12 ` Chris Wright
2009-06-02 10:14 ` [KVM PATCH v3 0/3] mmio/pio cleanup Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090601170613.GS20823@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=avi@redhat.com \
--cc=ghaskins@novell.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox