From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [PATCH] KVM: add localversion to avoid confusion and conflicts Date: Mon, 1 Jun 2009 15:26:24 -0400 Message-ID: <20090601192624.GA32428@goodmis.org> References: <1243581494.3212.1.camel@localhost.localdomain> <200905290948.34482.borntraeger@de.ibm.com> <1243586626.4379.15.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Christian =?iso-8859-1?Q?Borntr=E4ger?= , Avi Kivity , Ingo Molnar , LKML , KVM list To: Jaswinder Singh Rajput Return-path: Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:35812 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751823AbZFAT0X (ORCPT ); Mon, 1 Jun 2009 15:26:23 -0400 Content-Disposition: inline In-Reply-To: <1243586626.4379.15.camel@localhost.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, May 29, 2009 at 02:13:46PM +0530, Jaswinder Singh Rajput wrote: > On Fri, 2009-05-29 at 09:48 +0200, Christian Borntr=E4ger wrote: > > Am Freitag 29 Mai 2009 09:18:14 schrieb Jaswinder Singh Rajput: > > > Adding localversion avoids confusion in kernel images : > > > > > > like Linux version 2.6.30-rc7 does not tell whether it is linus o= r kvm > > > kernel. > > > > > > By adding localversion it tells : > > > > > > Linux version 2.6.30-rc7-kvm , any doubt ;-) > > > I am inspired by Ingo's -tip, I am sure Ingo will tell more advan= tages, > > > if these are not enough :-) > > [...] > > > diff --git a/localversion-kvm b/localversion-kvm > > > new file mode 100644 > > > index 0000000..d969ff0 > > > --- /dev/null > > > +++ b/localversion-kvm > > > @@ -0,0 +1 @@ > > > +-kvm > >=20 > > NAK from my side. If you need a distinction, there is always=20 > > CONFIG_LOCALVERSION_AUTO. If you need this kind of prefix, there is= always =20 > > CONFIG_LOCALVERSION. > >=20 >=20 > Here is NAK for your NAK from my side. And here is a NACK for your NACK of a NACK! >=20 > This patch is only for KVM tree and not for linus tree. >=20 > Lets assume 100 developers are working on kvm tree and they use kvm t= ree > on 2 PCs. So count becomes 200. >=20 > Like in my case I have dozen of kernel trees so I keep on swapping > config between kernels. And I also need to test config from various > users. So this count is countless. > I think this is the biggest point for adding localversion in -tip. > It seems Ingo is busy in perfcounter stuff otherwise he will explain = you > more advantages. >=20 > In the least case, Can you differentiate between 1 and 200 ? >=20 > So by adding this patch we can save lot of developer's time. No this patch wastes a lot of developers time. If we accept it, than an= y patch that is added after it will need to be rebased before going to Linus. Unless KVM is made up of a bunch of branches like tip is, this w= ill become more of a hassle than a benefit. Ingo's tip/master is based off of a bunch of branches. It is not recomm= ended to develope against tip/master. I develop against tip/tracing/core, becaus= e that is what will get pulled by Linus. tip/master is created automatically from= a bunch of branches and gets rebased all the time. One of those branches is tip, w= hich supplies the localversion. Thus, if you use tip/master, you get the localversion= file. But if you develop against one of the main branches that will eventually go= to Linus, then you will not have that localversion file. -- Steve