From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH RFC v3 3/4] Break dependency between vcpu index in vcpus array and vcpu_id.
Date: Tue, 2 Jun 2009 16:42:25 +0300 [thread overview]
Message-ID: <20090602134225.GC25846@redhat.com> (raw)
In-Reply-To: <20090602123808.GC4099@amt.cnet>
On Tue, Jun 02, 2009 at 09:38:08AM -0300, Marcelo Tosatti wrote:
> > @@ -2223,6 +2226,10 @@ static long kvm_vm_ioctl(struct file *filp,
> > r = kvm_irqfd(kvm, data.fd, data.gsi, data.flags);
> > break;
> > }
> > + case KVM_SET_BOOT_CPU_ID:
> > + kvm->bsp_vcpu_id = arg;
> > + r = 0;
> > + break;
>
> Don't you also need to update the bsp_vcpu pointer? And aren't these two
Actually I think I need to return an error if userspace tries to change BSP
after BSP cpu is already created.
> (bsp_vcpu pointer and bsp_vcpu_id) somewhat redundant?
>
Sometimes pointer to bsp vcpu is needed. It can be found looping over all
vcpus, but I prefer to have the pointer handy.
--
Gleb.
next prev parent reply other threads:[~2009-06-02 13:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 9:54 [PATCH RFC v3 0/4] decouple vcpu index from apic id Gleb Natapov
2009-05-28 9:54 ` [PATCH RFC v3 1/4] Introduce kvm_vcpu_is_bsp() function Gleb Natapov
2009-05-28 9:54 ` [PATCH RFC v3 2/4] Use pointer to vcpu instead of vcpu_id in timer code Gleb Natapov
2009-05-28 9:54 ` [PATCH RFC v3 3/4] Break dependency between vcpu index in vcpus array and vcpu_id Gleb Natapov
2009-06-02 12:38 ` Marcelo Tosatti
2009-06-02 13:42 ` Gleb Natapov [this message]
2009-05-28 9:54 ` [PATCH RFC v3 4/4] Use macro to iterate over vcpus Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090602134225.GC25846@redhat.com \
--to=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox