From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 2/3] KVM: VMX: Simplify pdptr and cr3 management Date: Tue, 2 Jun 2009 17:56:49 +0800 Message-ID: <200906021756.50038.sheng@linux.intel.com> References: <1243862524-22120-1-git-send-email-avi@redhat.com> <200906021730.38414.sheng@linux.intel.com> <4A24F4FF.70104@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti , Joerg Roedel To: Avi Kivity Return-path: Received: from mga12.intel.com ([143.182.124.36]:62067 "EHLO azsmga102.ch.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755382AbZFBJ4z (ORCPT ); Tue, 2 Jun 2009 05:56:55 -0400 In-Reply-To: <4A24F4FF.70104@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tuesday 02 June 2009 17:46:39 Avi Kivity wrote: > Sheng Yang wrote: > > No, no, not with the new code. For CPU can load pdptrs if EPT enabled > > with PAE from VM exit, there should not be necessary load it explicitly. > > So I estimate the ept_load_pdptr() in exit handler, and put it in CR0 > > handling. Just tried to optimize load-pdptr according to the spec, but > > not got the desired result... > > > > So I am trying to find the failure reason... > > so from your point of view, the patches are okay? Yes. But we should can optimize it more by avoiding most of PDPTR loading, according to the spec. -- regards Yang, Sheng