From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jens Axboe <qemu@kernel.dk>
Subject: Re: [PATCH 2/2] Add serial number support for virtio_blk, V4
Date: Wed, 3 Jun 2009 12:17:58 +0200
Message-ID: <20090603101758.GK11363@kernel.dk>
References: <4A1F615F.1090701@redhat.com> <200906011640.02632.rusty@rustcorp.com.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: john cooper <john.cooper@redhat.com>,
	KVM list <kvm@vger.kernel.org>, qemu-devel@nongnu.org,
	Christoph Hellwig <hch@lst.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Return-path: <kvm-owner@vger.kernel.org>
Received: from brick.kernel.dk ([93.163.65.50]:51307 "EHLO kernel.dk"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752764AbZFCKR5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 3 Jun 2009 06:17:57 -0400
Content-Disposition: inline
In-Reply-To: <200906011640.02632.rusty@rustcorp.com.au>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Jun 01 2009, Rusty Russell wrote:
> On Fri, 29 May 2009 01:45:27 pm john cooper wrote:
> > virtio_blk-serial-4.patch
> 
> Hate to ask dumb questions, but is there a scsi equivalent of this?  It'd be 
> nice if we could avoid being ATA-specific in the long run...

SCSI has mode pages, where ATA pretty much stuffs everything into the
identify data.

> Also, why u16?

The identify page is word based, so u16 makes sense.

> 
> Thanks,
> Rusty.
> 
> > +/* return ATA identify data
> > + */
> > +static int virtblk_identify(struct gendisk *disk, void *argp)
> > +{
> > +	struct virtio_blk *vblk = disk->private_data;
> > +	u16 *id;
> > +	int err = -ENOMEM;
> > +
> > +	id = kmalloc(VIRTIO_BLK_ID_BYTES, GFP_KERNEL);
> > +	if (!id)
> > +		goto out;
> > +
> > +	err = virtio_config_buf(vblk->vdev, VIRTIO_BLK_F_IDENTIFY,
> > +		offsetof(struct virtio_blk_config, identify), id,
> > +		VIRTIO_BLK_ID_BYTES);
> 

-- 
Jens Axboe