From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH 1/4] always halt non-bsp cpu. Date: Wed, 3 Jun 2009 13:32:22 +0300 Message-ID: <20090603103222.GA11384@redhat.com> References: <1243971470-31676-1-git-send-email-glommer@redhat.com> <1243971470-31676-2-git-send-email-glommer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:41505 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752411AbZFCKcW (ORCPT ); Wed, 3 Jun 2009 06:32:22 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n53AWPuC022983 for ; Wed, 3 Jun 2009 06:32:25 -0400 Content-Disposition: inline In-Reply-To: <1243971470-31676-2-git-send-email-glommer@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Jun 02, 2009 at 03:37:47PM -0400, Glauber Costa wrote: > This is not kvm specific, and should do fine in plain qemu > > Signed-off-by: Glauber Costa > --- > hw/apic.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/hw/apic.c b/hw/apic.c > index 86aa6b6..2eddba0 100644 > --- a/hw/apic.c > +++ b/hw/apic.c > @@ -467,8 +467,7 @@ static void apic_init_ipi(APICState *s) > > cpu_reset(s->cpu_env); > > - if (!(s->apicbase & MSR_IA32_APICBASE_BSP) && > - (!kvm_enabled() || !qemu_kvm_irqchip_in_kernel())) > + if (!(s->apicbase & MSR_IA32_APICBASE_BSP)) > s->cpu_env->halted = 1; > > if (kvm_enabled() && !qemu_kvm_irqchip_in_kernel()) Once upon a time there was a good reason to add this: 358bdca5beb733c983bd5e7406c7893e19e9600b What have changed? -- Gleb.