From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] use KVMState, as upstream do Date: Thu, 4 Jun 2009 23:17:48 +0300 Message-ID: <20090604201748.GH18757@redhat.com> References: <1244139783-15787-1-git-send-email-glommer@redhat.com> <20090604192329.GD18757@redhat.com> <20090604193319.GG30777@poweredge.glommer> <20090604200046.GE18757@redhat.com> <20090604201051.GH30777@poweredge.glommer> <20090604200952.GG18757@redhat.com> <20090604201806.GI30777@poweredge.glommer> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, avi@redhat.com To: Glauber Costa Return-path: Received: from mx2.redhat.com ([66.187.237.31]:39353 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751077AbZFDURs (ORCPT ); Thu, 4 Jun 2009 16:17:48 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n54KHp7t018676 for ; Thu, 4 Jun 2009 16:17:51 -0400 Content-Disposition: inline In-Reply-To: <20090604201806.GI30777@poweredge.glommer> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 04, 2009 at 05:18:06PM -0300, Glauber Costa wrote: > > > this first phase has nothing to do with functionality. To begin with, > > > KVMState is qemu style, kvm_context_t is not, like it or not (I don't). > > > > > I am not against this mechanical change at all, don't get me wrong. I > > don't want to mix two kvm implementation together in strange ways. > > > too late for not wanting anything strange to happen ;-) > You are right, I should have said "in stranger ways". > But I do believe this is the way to turn qemu-kvm.git into something > that feeds qemu.git. And that's what we all want. Disagree with first part, agree with second :) -- Gleb.