From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] cleanup acpi table creation Date: Mon, 8 Jun 2009 14:33:41 +0300 Message-ID: <20090608113341.GC27210@redhat.com> References: <20090604124423.GN11384@redhat.com> <4A2CF60C.7080807@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:60842 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754519AbZFHLdl (ORCPT ); Mon, 8 Jun 2009 07:33:41 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n58BXiIr019385 for ; Mon, 8 Jun 2009 07:33:44 -0400 Content-Disposition: inline In-Reply-To: <4A2CF60C.7080807@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 08, 2009 at 02:29:16PM +0300, Avi Kivity wrote: > Gleb Natapov wrote: >> Current code is a mess. And addition of acpi tables is broken. >> > > Sorry, this patch is impossible to review. Please send the shortest > possible fix, even if it remains hacky. We'll switch to seabios as soon > as possible, so I don't think it makes sense to clean this up. > seabios has the same ugly code. -- Gleb.