From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH 2/4] sipi and init: move common code Date: Mon, 8 Jun 2009 12:52:53 -0300 Message-ID: <20090608155253.GA11966@poweredge.glommer> References: <1244063970-13913-1-git-send-email-glommer@redhat.com> <1244063970-13913-2-git-send-email-glommer@redhat.com> <1244063970-13913-3-git-send-email-glommer@redhat.com> <4A2CD501.1020007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37755 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973AbZFHPqw (ORCPT ); Mon, 8 Jun 2009 11:46:52 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n58FktXe014703 for ; Mon, 8 Jun 2009 11:46:55 -0400 Content-Disposition: inline In-Reply-To: <4A2CD501.1020007@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jun 08, 2009 at 12:08:17PM +0300, Avi Kivity wrote: > Glauber Costa wrote: >> provide functions to query and reset the state of sipi and >> init in cpu's apic. This way we can move the kvm specific functions >> out of the apic path. >> >> > > The new functions and data members are kvm specific. Please update > their names to reflect that. 'sipi_needed' would be really confusing > for someone reading the code from a tcg perspective (it's confusing even > from a kvm perspective, but that's our problem and can be addressed > later). The idea of such series is exactly to write it in a way that is _not_ kvm specific, although kvm is the only user. So, I may change the name if you prefer, but I would not like to introduce any "kvm" string on it. To do that, we might as well stick with what we have.