Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

Anthony Liguori
2009-06-15T15:11:24Z

Michael S. Tsirkin wrote:
> And then pc-virtio-class-other-with-balloon-without-usb? Wouldn't it be
> more straightforward to have capability bits which can be switched on
> and off independently rather than trying to fit unrelated features into
> a machine type? IMO it only seems more work at first, and QA gets a bit
> nervious that they can't exhaustively test all options. But in the long
> run it simplifies things as you don't have to set policy and invent
> silly names.
>

We're strictly talking about default machine configs. That has nothing
to do with capabilities. You still need to know what the default set of
enabled capabilities were and keep track of that. All that I'm
suggesting is that we use the machine name to collapse the default set
of capabilities into something that libvirt can track.

The advantage of using something more opaque like that is that it
simplifies things for management tools as they don't have to keep track
of "capabilities" that we're adding. Heck, you could even do:

pc-00000034

Where "pc-%08x" % (capabilities) :-)

Regards,

Anthony Liguori