Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3 03/13] qemu: add routines to manage PCI capabilities]

Avi Kivity
2009-06-15T13:11:20Z

On 06/15/2009 03:52 PM, Anthony Liguori wrote:
> Avi Kivity wrote:
>> On 06/15/2009 03:41 PM, Michael S. Tsirkin wrote:
>>> We should just tell the user which slots are open.
>>> This might be tricky if the config is passed in with the command line
>>> flags.
>>
>> qemu -show-available-pci-slots
>
> Why does the user care?
>
> Let QEMU allocate the PCI slot, then query it to see what slot it
> assigned and remember that.

It's a roundabout way of doing things.

As an example, if you try to fit too many devices into the machine, you
have to try to add all devices and watch for a qemu error. If you know
in advance how many slots you have, you never enter into that situation
(and you need to show the limit to the user anyway).

>
> It's not a good idea to have management applications attempt to do PCI
> slot allocation. For instance, one day we may decide to make virtio
> devices multi-function.

Non-virtio, as well. But we can't make that the default, so the user
will have to specify this anyway.

Given that you can't hotunplug individual functions, the user will have
to specify exactly how functions are aggregated into devices. My
recommendation would be for a GUI to allow the user to select a 'quad
port virtio NIC' or 'dual port virtio scsi controller' rather than
trying to do anything automatic.

--
error compiling committee.c: too many arguments to function