From mboxrd@z Thu Jan  1 00:00:00 1970
From: Glauber Costa <glommer@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3 12/13] qemu: virtio save/load bindings
Date: Tue, 9 Jun 2009 14:45:54 -0300
Message-ID: <20090609174554.GD19375@poweredge.glommer>
References: <cover.1244192535.git.mst@redhat.com> <20090605102426.GM26770@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Blue Swirl <blauwirbel@gmail.com>,
	Anthony Liguori <anthony@codemonkey.ws>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:58431 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752336AbZFIRmf (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 9 Jun 2009 13:42:35 -0400
Content-Disposition: inline
In-Reply-To: <20090605102426.GM26770@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

duplicated save config.

> diff --git a/hw/virtio.h b/hw/virtio.h
> index 04a3c3d..ce05517 100644
> --- a/hw/virtio.h
> +++ b/hw/virtio.h
> @@ -72,6 +72,10 @@ typedef struct VirtQueueElement
>  
>  typedef struct {
>      void (*notify)(void * opaque, uint16_t vector);
> +    void (*save_config)(void * opaque, QEMUFile *f);
> +    void (*save_queue)(void * opaque, int n, QEMUFile *f);
> +    int (*load_config)(void * opaque, QEMUFile *f);
> +    int (*load_queue)(void * opaque, int n, QEMUFile *f);
>  } VirtIOBindings;
>  
So, what's the overall effect on a virtual machine that gets migrated,
of a certain device not implementing one of those functions? Will it work?
Will it break?