public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: Ryan Harper <ryanh@us.ibm.com>, kvm@vger.kernel.org
Subject: Re: BUG at mmu.c:615 from localhost migration using ept+hugetlbfs
Date: Wed, 10 Jun 2009 09:10:00 -0300	[thread overview]
Message-ID: <20090610121000.GA6672@amt.cnet> (raw)
In-Reply-To: <4A2F69EE.9080503@redhat.com>

On Wed, Jun 10, 2009 at 11:08:14AM +0300, Avi Kivity wrote:
> Avi Kivity wrote:
>>
>> Not really.  One thing, migration should transition the shadow  
>> pagetables from large pages to small ones, maybe that bit is broken.
>>
>> Maybe we're looking at a largepage spte and interpreting it as a  
>> normal L2 spte, and interpreting a guest page as the L1 spt.
>
> I tried to find where we drop the mmu (or at least large sptes for the  
> slot) when we enable dirty logging, and failed.  Maybe  
> remove_write_access() is sufficient.

I believe you have to break down large pages into 4k pages for migration
to work reliably. Was tempted to copy&paste the hugetlbfs file ram alloc
code into user/main.c to use with user/vm.c (which then can also be used
to test TLB flushes on 2M->4k transition which are lacking).

Regarding the bogus spte, could not reproduce yesterday with kvm.git,
but in the worst case the audit code will catch it.


  reply	other threads:[~2009-06-10 12:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-29 16:43 BUG at mmu.c:615 from localhost migration using ept+hugetlbfs Ryan Harper
2009-06-09 16:40 ` Marcelo Tosatti
2009-06-09 16:47   ` Avi Kivity
2009-06-10  8:08     ` Avi Kivity
2009-06-10 12:10       ` Marcelo Tosatti [this message]
2009-06-09 18:31   ` Ryan Harper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090610121000.GA6672@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=ryanh@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox