From: Jesse Barnes <jesse.barnes@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org
Subject: Re: [PATCH] msi-x: let drivers retry when not enough vectors
Date: Thu, 11 Jun 2009 11:28:18 -0700 [thread overview]
Message-ID: <20090611112818.149b568e@jbarnes-g45> (raw)
In-Reply-To: <20090507082841.GA31751@redhat.com>
On Thu, 7 May 2009 11:28:41 +0300
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> pci_enable_msix currently returns -EINVAL if you ask
> for more vectors than supported by the device, which would
> typically cause fallback to regular interrupts.
>
> It's better to return the table size, making the driver retry
> MSI-X with less vectors.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Hi Jesse,
> This came up when I was adding MSI-X support to virtio pci driver,
> which does not know the exact table size upfront.
> Could you consider this patch for 2.6.31 please?
Applied this one to my linux-next branch; hopefully Rusty won't mind
too much. :)
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-06-11 18:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 8:28 [PATCH] msi-x: let drivers retry when not enough vectors Michael S. Tsirkin
2009-05-07 8:51 ` Sheng Yang
2009-05-07 9:05 ` Michael S. Tsirkin
2009-05-07 9:10 ` Sheng Yang
2009-05-07 9:31 ` Michael S. Tsirkin
2009-05-07 9:27 ` Matthew Wilcox
2009-05-07 9:40 ` Sheng Yang
2009-05-07 9:53 ` Matthew Wilcox
2009-05-07 10:19 ` Sheng Yang
2009-05-07 10:32 ` Michael S. Tsirkin
2009-05-07 23:55 ` Rusty Russell
2009-05-08 0:22 ` Matthew Wilcox
2009-05-08 0:28 ` Michael Ellerman
2009-05-12 21:28 ` Michael S. Tsirkin
2009-05-07 10:23 ` Michael Ellerman
2009-05-07 10:28 ` Sheng Yang
2009-05-07 10:44 ` Avi Kivity
2009-05-07 11:57 ` Matthew Wilcox
2009-06-11 18:28 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090611112818.149b568e@jbarnes-g45 \
--to=jesse.barnes@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox