Re: [patch 2/5] KVM: MMU: make for_each_shadow_entry aware of largepages

Avi Kivity
2009-06-11T14:17:53Z

Marcelo Tosatti wrote:
>>>> @@ -1273,6 +1273,11 @@ static bool shadow_walk_okay(struct kvm_
>>>> {
>>>> if (iterator->level < PT_PAGE_TABLE_LEVEL)
>>>> return false;
>>>> +
>>>> + if (iterator->level == PT_PAGE_TABLE_LEVEL)
>>>> + if (is_large_pte(*iterator->sptep))
>>>> + return false;
>>>>
>>>>
>>>>
>>> s/==/>/?
>>>
>>>
>> Ah, it's actually fine. But changing == to >= will make it 1GBpage-ready.
>>
>
> Humpf, better check level explicitly before interpreting bit 7, so lets
> skip this for 1GB pages.
>
>

Okay. But I'm rewriting shadow_walk_* afterwards.

--
error compiling committee.c: too many arguments to function