Re: [patch 2/5] KVM: MMU: make for_each_shadow_entry aware of largepages

Avi Kivity
2009-06-10T09:15:03Z

Marcelo Tosatti wrote:
> This way there is no need to add explicit checks in every
> for_each_shadow_entry user.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> Index: kvm/arch/x86/kvm/mmu.c
> ===================================================================
> --- kvm.orig/arch/x86/kvm/mmu.c
> +++ kvm/arch/x86/kvm/mmu.c
> @@ -1273,6 +1273,11 @@ static bool shadow_walk_okay(struct kvm_
> {
> if (iterator->level < PT_PAGE_TABLE_LEVEL)
> return false;
> +
> + if (iterator->level == PT_PAGE_TABLE_LEVEL)
> + if (is_large_pte(*iterator->sptep))
> + return false;
>
>
s/==/>/?

--
error compiling committee.c: too many arguments to function