From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: Configuration vs. compat hints [was Re: [Qemu-devel] [PATCHv3
	03/13] qemu: add routines to manage PCI capabilities]
Date: Fri, 12 Jun 2009 16:59:36 +0300
Message-ID: <20090612135936.GA25912@redhat.com>
References: <cover.1244192535.git.mst@redhat.com> <20090610145540.GI19375@poweredge.glommer> <20090610150129.GC28601@redhat.com> <200906101624.30659.paul@codesourcery.com> <20090610174301.GC7416@shareable.org> <20090610182227.GN28601@redhat.com> <20090610192702.GH7416@shareable.org> <1244796209.16425.20.camel@blaa>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Jamie Lokier <jamie@shareable.org>,
	Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org,
	Glauber Costa <glommer@redhat.com>,
	Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org,
	virtualization@lists.linux-foundation.org,
	Blue Swirl <blauwirbel@gmail.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:51572 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759993AbZFLOCr (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 12 Jun 2009 10:02:47 -0400
Content-Disposition: inline
In-Reply-To: <1244796209.16425.20.camel@blaa>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Jun 12, 2009 at 09:43:29AM +0100, Mark McLoughlin wrote:
> = Solution - Separate configuration from compat hints =
> 
> As I suggested before:
> 
>   - Allow the VM manager to dump compat hints; this would be an opaque 
>     file format, more like the savevm format than a config file

Why make it "like the savevm" format then?
If they are opaque anyway, compat hints could be part of savevm format.

>   - Use defaults where compat hints are not available; e.g. if the VM 
>     manager specifies a device config, but no compat hints are 
>     supplied for it, then just use default values
> 
>   - Make the config override compat hints; e.g. if there are compat 
>     hints specified for a device not included in the machine config, 
>     just ignore those hints
> 
> Cheers,
> Mark.

If compat hints are opaque and only editable by qemu, we can get into a
situation where one can't create a specific setup with a new qemu.

-- 
MST