[KVM PATCH v6 0/2] iosignalfd

Gregory Haskins
2009-06-05T15:55:09Z

[
Applies to kvm.git/master:0281e88f as a base, plus Marcelo's irq locking
rework v4, which you can find here:

http://www.mail-archive.com/kvm@vger.kernel.org/msg16494.html

You can find the entire series here in my git tree:

http://git.kernel.org/?p=linux/kernel/git/ghaskins/linux-2.6-hacks.git;a=shortlog;h=for-avi

Note: I didn't find any conflicts or things that needed addressing when
rebasing to Marcelo's series, so the two may in fact be applied
indepenently if need be.

]

This is v6 of the series. For more details, please see the header to
patch 2/2.

This series has been tested against the kvm-eventfd unit test, and
appears to be functioning properly. You can download this test here:

ftp://ftp.novell.com/dev/ghaskins/kvm-eventfd.tar.bz2

[
Todo before "consider for inclusion" ready:
*) There is still some confusion whether I am doing the "kvm-shutdown"
path properly from a private discussion I had with Marcelo, so
this needs to be cleared up before it can be accepted.
*) As agreed, Marcelo's code need to get committed first
]

[
Changelog:

v6:
*) Removed "FIXME?" comment on choice over RCU vs SRCU after
discussion/numbers from Paul. I think RCU is fine to use for
now based on the conversation. We can always convert it later
if need be.
*) Fixed the "group" free path to eliminate an RCU related race
*) Fixed a memory/eventfd leak on shutdown for any iosignalfd's
which were still active at the time the guest shuts down.
*) Beefed up comments
*) Rebased to kvm.git/master:0281e88f + irq locking rework and
verified that kvm-eventfd unit test still passes.

v5:
*) Removed "cookie" field, which was a misunderstanding on my
part on what Avi wanted for a data-match feature
*) Added a new "trigger" data-match feature which I think is
much closer to what we need.
*) We retain the dev_count field in the io_bus infrastructure
and instead back-fill the array on removal.
*) Various minor cleanups
*) Rebased to kvm.git/master:25deed73

v4:
*) Fixed a bug in the original 2/4 where the PIT failure case
would potentially leave the io_bus components registered.
*) Condensed the v3 2/4 and 3/4 into one patch (2/2) since
the patches became interdependent with the fix described above
*) Rebased to kvm.git/master:74dfca0a

v3:
*) fixed patch 2/4 to handle error cases instead of BUG_ON
*) implemented same HAVE_EVENTFD protection mechanism as
irqfd to prevent compilation errors on unsupported arches
*) completed testing
*) rebased to kvm.git/master:7391a6d5

v2:
*) added optional data-matching capability (via cookie field)
*) changed name from iofd to iosignalfd
*) added io_bus unregister function
*) implemented deassign feature

v1:
*) original release (integrated into irqfd v7 series as "iofd")
]

---

Gregory Haskins (2):
KVM: add iosignalfd support
KVM: make io_bus interface more robust

arch/x86/kvm/i8254.c | 22 ++-
arch/x86/kvm/i8259.c | 9 +
arch/x86/kvm/x86.c | 1
include/linux/kvm.h | 15 ++
include/linux/kvm_host.h | 16 +-
virt/kvm/coalesced_mmio.c | 8 +
virt/kvm/eventfd.c | 389 +++++++++++++++++++++++++++++++++++++++++++++
virt/kvm/ioapic.c | 9 +
virt/kvm/kvm_main.c | 41 ++++-
9 files changed, 495 insertions(+), 15 deletions(-)

--
Signature