From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCHv5 08/13] qemu: add support for resizing regions Date: Thu, 18 Jun 2009 19:44:44 +0300 Message-ID: <20090618164444.GB19553@redhat.com> References: <20090618131438.GI19092@redhat.com> <200906181735.10458.paul@codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, Avi Kivity , Carsten Otte , kvm@vger.kernel.org, Rusty Russell , virtualization@lists.linux-foundation.org, Christian Borntraeger , Blue Swirl , Anthony Liguori , Glauber Costa To: Paul Brook Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37972 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbZFRQrk (ORCPT ); Thu, 18 Jun 2009 12:47:40 -0400 Content-Disposition: inline In-Reply-To: <200906181735.10458.paul@codesourcery.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Jun 18, 2009 at 05:32:11PM +0100, Paul Brook wrote: > On Thursday 18 June 2009, Michael S. Tsirkin wrote: > > Make it possible to resize PCI regions. This will be used by virtio > > with MSI-X, where the region size depends on whether MSI-X is enabled, > > and can change across load/save. > > I thought we'd agreed we shouldn't be doing this. > i.e. if the user tries to load the wrong device, just bail out. > > Paul We need a way to generally prevent load from changing registers in a way that can not be done by a guest. I haven't implemented this feature yet though. -- MST