From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] Cleanup cpu loop
Date: Mon, 22 Jun 2009 16:41:00 +0300
Message-ID: <20090622134100.GB15865@redhat.com>
References: <20090618122228.GE20289@redhat.com> <4A3F878B.9080406@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:55030 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750866AbZFVNlC (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 22 Jun 2009 09:41:02 -0400
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n5MDf5Si027806
	for <kvm@vger.kernel.org>; Mon, 22 Jun 2009 09:41:05 -0400
Content-Disposition: inline
In-Reply-To: <4A3F878B.9080406@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Jun 22, 2009 at 04:30:51PM +0300, Avi Kivity wrote:
> On 06/18/2009 03:22 PM, Gleb Natapov wrote:
>> Rearrange cpu loop to be (hopefully) more readable. Put difference
>> between kernel/userspace irqchip in one place.
>>
>>
>>   static void flush_queued_work(CPUState *env)
>> @@ -1877,6 +1871,8 @@ static void update_regs_for_init(CPUState *env)
>>   #endif
>>
>>       cpu_reset(env);
>> +    /* cpu_reset() clears env->halted, cpu should be halted after init */
>> +    env->halted = 1;
>>    
>
> How does that work for the boot cpu?

void kvm_apic_init(CPUState *env)
{
    if (env->cpu_index != 0)
        env->kvm_cpu_state.init = 1;
    kvm_update_interrupt_request(env);
}

Boot cpu does not get here.

--
			Gleb.