From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 2/8] kvm: change memslot data structures for multiple hugepage sizes Date: Tue, 23 Jun 2009 13:49:20 -0300 Message-ID: <20090623164920.GC3651@amt.cnet> References: <1245417389-5527-1-git-send-email-joerg.roedel@amd.com> <1245417389-5527-3-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Marcelo Tosatti , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx2.redhat.com ([66.187.237.31]:37516 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753081AbZFWQug (ORCPT ); Tue, 23 Jun 2009 12:50:36 -0400 Content-Disposition: inline In-Reply-To: <1245417389-5527-3-git-send-email-joerg.roedel@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jun 19, 2009 at 03:16:23PM +0200, Joerg Roedel wrote: > /* > @@ -724,11 +724,11 @@ static int kvm_handle_hva(struct kvm *kvm, unsigned long hva, > end = start + (memslot->npages << PAGE_SHIFT); > if (hva >= start && hva < end) { > gfn_t gfn_offset = (hva - start) >> PAGE_SHIFT; > + int idx = gfn_offset / > + KVM_PAGES_PER_HPAGE(PT_DIRECTORY_LEVEL); > retval |= handler(kvm, &memslot->rmap[gfn_offset]); > retval |= handler(kvm, > - &memslot->lpage_info[ > - gfn_offset / > - KVM_PAGES_PER_HPAGE].rmap_pde); > + &memslot->lpage_info[0][idx].rmap_pde); > } Cannot find where you update this function to reflect 1GB pages in the series?