Re: virtio-serial: A guest <-> host interface for simple communication

Rusty Russell
2009-06-24T04:15:01Z

On Tue, 23 Jun 2009 10:12:31 pm Amit Shah wrote:
> Hello,
>
> Here are two patches. One implements a virtio-serial device in qemu
> and the other is the driver for a guest kernel.
>
> While working on a vmchannel interface that is needed for communication
> between guest userspace and host userspace, I saw that most of the
> interface can be abstracted out as a "serial" device with "ports".

OK, I don't think the "naming" idea works though. A userspace user would have
to open each one in turn to get its name. I'd stick with numbers.

You also don't have dynamic creation and removal, except by hotpluging the
entire device (which was on your requirements page).

I'd put a size and bitmap in the configuration space, and use that to indicate
what ports exist. Register on the change interrupt to get updates. Drop the
control vq entirely.

Cheers,
Rusty.