From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: virtio-serial: A guest <-> host interface for simple communication Date: Wed, 24 Jun 2009 13:45:01 +0930 Message-ID: <200906241345.02051.rusty@rustcorp.com.au> References: <1245760953-32139-1-git-send-email-amit.shah@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Amit Shah , qemu-devel@nongnu.org, kvm@vger.kernel.org To: virtualization@lists.linux-foundation.org Return-path: Received: from ozlabs.org ([203.10.76.45]:46744 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbZFXEPB (ORCPT ); Wed, 24 Jun 2009 00:15:01 -0400 In-Reply-To: <1245760953-32139-1-git-send-email-amit.shah@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Tue, 23 Jun 2009 10:12:31 pm Amit Shah wrote: > Hello, > > Here are two patches. One implements a virtio-serial device in qemu > and the other is the driver for a guest kernel. > > While working on a vmchannel interface that is needed for communication > between guest userspace and host userspace, I saw that most of the > interface can be abstracted out as a "serial" device with "ports". OK, I don't think the "naming" idea works though. A userspace user would have to open each one in turn to get its name. I'd stick with numbers. You also don't have dynamic creation and removal, except by hotpluging the entire device (which was on your requirements page). I'd put a size and bitmap in the configuration space, and use that to indicate what ports exist. Register on the change interrupt to get updates. Drop the control vq entirely. Cheers, Rusty.